Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20692 )
Change subject: IMPALA-11542: Implement pre-allocation in LLVM memory manager ...................................................................... Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#/c/20692/13/be/src/thirdparty/llvm/SectionMemoryManager.h File be/src/thirdparty/llvm/SectionMemoryManager.h: http://gerrit.cloudera.org:8080/#/c/20692/13/be/src/thirdparty/llvm/SectionMemoryManager.h@55 PS13, Line 55: bool needsToReserveAllocationSpace() override { return true; } > I'm somewhat tempted to have this controllable by a flag, so we can disable The other option would be to only enable it on aarch64, which would limit the impact. -- To view, visit http://gerrit.cloudera.org:8080/20692 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9f224edcdbdcb05fce663c18b4a5f03c8e985675 Gerrit-Change-Number: 20692 Gerrit-PatchSet: 13 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Comment-Date: Wed, 29 Nov 2023 18:42:39 +0000 Gerrit-HasComments: Yes
