Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3823: Add timer to measure Parquet footer reads ......................................................................
Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/4371/4/be/src/util/runtime-profile-counters.h File be/src/util/runtime-profile-counters.h: PS4, Line 147: . > When you say 'child counters', do you mean it in the terms of the child cou Yeah, ignore this. I was trying to further differentiate this from the new counter. In the future we can think about cleaning up all the different kinds of Counters we have. http://gerrit.cloudera.org:8080/#/c/4371/5/be/src/util/runtime-profile.cc File be/src/util/runtime-profile.cc: PS5, Line 1020: } : : voi 1 line PS5, Line 1023: lock_guard<SpinLock> l(counter_lock_); : unit_ = counter.unit; : c 1 line http://gerrit.cloudera.org:8080/#/c/4371/5/tests/query_test/test_scanners.py File tests/query_test/test_scanners.py: Line 338: # scan and process the Parquet footer across scan ranges and also records the min and can you add a TODO for handling the case when there is more than one range per node? You can add it requires parsing the times and there is unit test coverage. -- To view, visit http://gerrit.cloudera.org:8080/4371 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf87bad90037dd0cea63b10c537382ec0f980cbf Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-HasComments: Yes
