Sailesh Mukil has posted comments on this change. Change subject: IMPALA-3823: Add timer to measure Parquet footer reads ......................................................................
Patch Set 6: Code-Review+1 (3 comments) Carry +1 http://gerrit.cloudera.org:8080/#/c/4371/5/be/src/util/runtime-profile.cc File be/src/util/runtime-profile.cc: PS5, Line 1020: if (new_value < min_) { min_ = new_value; } : if (new_value > max_) { max_ = new_value; } : } > 1 line Done PS5, Line 1023: : void RuntimeProfile::SummaryStatsCounter::SetStats(const TSummaryStatsCounter& counter) { : l > 1 line Done http://gerrit.cloudera.org:8080/#/c/4371/5/tests/query_test/test_scanners.py File tests/query_test/test_scanners.py: Line 338: # and average values as the same since we have only one sample (i.e. only one range) > can you add a TODO for handling the case when there is more than one range Done -- To view, visit http://gerrit.cloudera.org:8080/4371 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf87bad90037dd0cea63b10c537382ec0f980cbf Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-HasComments: Yes
