Tim Armstrong has posted comments on this change. Change subject: IMPALA-3308: Get expr-test passing on PPC64LE ......................................................................
Patch Set 3: (2 comments) No problems, just wanted to make sure that this patch made it it. http://gerrit.cloudera.org:8080/#/c/4186/3/be/src/exprs/expr-value.h File be/src/exprs/expr-value.h: Line 70: /// Init for string values Can you remove this comment? It's not helpful (I know you didn't add it :)). Line 71: void Init(const std::string& str){ Can you fix the missing whitespace in this line and the one below. Probably the easiest is to run clang-format on the patch (we recently added a .clang-format file). This command will run clang-format on the lines changed in the most recent commit on your branch: git diff -U0 HEAD^ | $IMPALA_TOOLCHAIN/llvm-3.8.0-p1/share/clang/clang-format-diff.py -i -p1 -- To view, visit http://gerrit.cloudera.org:8080/4186 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4504ee6a52a085f530aadfcfa009bacb83c64787 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: segelyang <zhiz...@cn.ibm.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: segelyang <zhiz...@cn.ibm.com> Gerrit-HasComments: Yes
