Tim Armstrong has posted comments on this change. Change subject: IMPALA-3308: Get expr-test passing on PPC64LE ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4186/3/be/src/exprs/expr-value.h File be/src/exprs/expr-value.h: PS3, Line 73: string_val.ptr = const_cast<char*>(string_data.data()); > I think string_data[0] has type const char&, so I'm not sure that will work There's a non-const char version http://www.cplusplus.com/reference/string/string/operator[]/. This function should be the only place that string_data is touched. -- To view, visit http://gerrit.cloudera.org:8080/4186 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4504ee6a52a085f530aadfcfa009bacb83c64787 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: segelyang <zhiz...@cn.ibm.com> Gerrit-Reviewer: Jim Apple <jbap...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: segelyang <zhiz...@cn.ibm.com> Gerrit-HasComments: Yes
