Huaisi Xu has posted comments on this change. Change subject: IMPALA-1702: Enforce table level consistency ......................................................................
Patch Set 10: (6 comments) http://gerrit.cloudera.org:8080/#/c/4349/10/fe/src/main/java/org/apache/impala/analysis/DescriptorTable.java File fe/src/main/java/org/apache/impala/analysis/DescriptorTable.java: Line 155: * Connect tupleDescriptors to tableDescriptors with unique table ids and get > Returns the thrift representation of this DescriptorTable. Assigns unique i Done http://gerrit.cloudera.org:8080/#/c/4349/10/fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java File fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java: Line 418: * Our single query table consistency guarantee: > Way too elaborate this comment. just say: Done Line 422: * 2. All tables reference to the same version of table in Analyzer::getTable(). > Remove this block Done Line 426: private void validateTableConsistency(TExecRequest request) { > validateTableIds Done Line 433: for (TTableDescriptor tableDesc: descTbl.tableDescriptors) { > This code seems pretty elaborate for checking unique ids. Wouldn't it be su Done. but that way we do not know the old table's name. Line 437: throw new IllegalStateException("Failed to verify table consistency for" + > We're not validating table consistency. Error report should be consistent w Done -- To view, visit http://gerrit.cloudera.org:8080/4349 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifad648b72684ae495ec387590ab1bc58ce5b39e2 Gerrit-PatchSet: 10 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Huaisi Xu <h...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Huaisi Xu <h...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
