Alex Behm has posted comments on this change. Change subject: IMPALA-1702: Enforce table level consistency ......................................................................
Patch Set 12: (8 comments) Almost there http://gerrit.cloudera.org:8080/#/c/4349/12//COMMIT_MSG Commit Message: Line 7: IMPALA-1702: Enforce table level consistency Enforce single-table consistency in query analysis. Line 10: new update arrives at frontend while queries are being new updates arrive at the frontend Line 12: to a different version, and different table may share the different tables Line 14: another in the backend table map. another one in the thrift descriptor table sent to the backend. Line 16: This commit removes table id from the Table object; instead removes the table if from the catalog Table object Line 17: frontend assigns a unique id to each table just before the frontend assigns a unique id to each table in DescriptorTable.toThrift(). http://gerrit.cloudera.org:8080/#/c/4349/12/fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java File fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java: Line 417: * Validates that all tables in the descriptor table of 'request' have a unique id. Validates that all tables in the descriptor table of 'request' have a unique id and those are properly referenced by other thrift structures (tuple descriptors, table sink). Line 434: for (TTupleDescriptor tupleDesc: descTbl.tupleDescriptors) { also check the table sink's id (if there is a sink) -- To view, visit http://gerrit.cloudera.org:8080/4349 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifad648b72684ae495ec387590ab1bc58ce5b39e2 Gerrit-PatchSet: 12 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Huaisi Xu <h...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Huaisi Xu <h...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
