Alex Behm has posted comments on this change. Change subject: IMPALA-2789: More compact mem layout with null bits at the end. ......................................................................
Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/4673/5/be/src/benchmarks/row-batch-serialize-benchmark.cc File be/src/benchmarks/row-batch-serialize-benchmark.cc: Line 97: scoped_ptr<Frontend> fe; > static? Done http://gerrit.cloudera.org:8080/#/c/4673/5/be/src/runtime/row-batch-test.cc File be/src/runtime/row-batch-test.cc: Line 35: scoped_ptr<Frontend> fe; > static Done http://gerrit.cloudera.org:8080/#/c/4673/5/common/thrift/Frontend.thrift File common/thrift/Frontend.thrift: Line 753: // For creating a test descriptor table. The tuples and their > Comment wrapping seems weird. Done http://gerrit.cloudera.org:8080/#/c/4673/5/fe/src/main/java/org/apache/impala/analysis/DescriptorTable.java File fe/src/main/java/org/apache/impala/analysis/DescriptorTable.java: Line 205: * Creates a thrift descriptor table for testing. Each entry in 'slotTypes' > Comment wrapping seems weird. Done -- To view, visit http://gerrit.cloudera.org:8080/4673 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib6510c75d841bddafa6638f1bd2ac6731a7053f6 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
