Alex Behm has posted comments on this change. Change subject: IMPALA-2789: More compact mem layout with null bits at the end. ......................................................................
Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/4673/7/be/src/runtime/descriptors.cc File be/src/runtime/descriptors.cc: Line 603: builder.CreateInBoundsGEP(tuple_int8_ptr, null_byte_offset, "null_byte_ptr"); > why is this change necessary? Before we were accessing the null byte as a struct field via GetStructGEP(), i.e. assuming that null_indicator_offset_.byte_offset indicated the field of the tuple struct we want to access. I've changed this to cast the tuple to an int8_t* and then access the bull byte via the offset (and not as a field in the tuple struct) using CreateInboundsGEP(). -- To view, visit http://gerrit.cloudera.org:8080/4673 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib6510c75d841bddafa6638f1bd2ac6731a7053f6 Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
