Dan Hecht has posted comments on this change. Change subject: IMPALA-2789: More compact mem layout with null bits at the end. ......................................................................
Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/4673/7/be/src/runtime/descriptors.cc File be/src/runtime/descriptors.cc: PS7, Line 575: // (in this case the tuple contains only a nullable double) : // define void @SetNotNull({ i8, double }* %tuple) { : // entry: : // %null_byte_ptr = getelementptr inbounds { i8, double }* %tuple, i32 0, i32 0 : // %null_byte = load i8* %null_byte_ptr : // %0 = and i8 %null_byte, -2 : // store i8 %0, i8* %null_byte_ptr : // ret void this looks outdated. -- To view, visit http://gerrit.cloudera.org:8080/4673 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib6510c75d841bddafa6638f1bd2ac6731a7053f6 Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes