Dan Hecht has posted comments on this change. Change subject: IMPALA-3788: Support for Kudu 'read-your-writes' consistency ......................................................................
Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/4779/3/be/src/service/impala-server.cc File be/src/service/impala-server.cc: Line 1163: if (kudu_latest_observed_ts > 0) { why not carry the > 0 convention and just always set the session state? looks like scan node already checks > 0 anyway. http://gerrit.cloudera.org:8080/#/c/4779/3/be/src/service/query-exec-state.cc File be/src/service/query-exec-state.cc: Line 547: } why is it better to do here rather than, say, ImpalaServer::UnregisterQuery()? is it important that we're holding QES::lock_? http://gerrit.cloudera.org:8080/#/c/4779/3/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: Line 322 nice to see this go -- To view, visit http://gerrit.cloudera.org:8080/4779 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6bcb5fc218ad4ab935343a55b2188441d8c7dfbd Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-HasComments: Yes
