Dan Hecht has posted comments on this change. Change subject: IMPALA-3788: Support for Kudu 'read-your-writes' consistency ......................................................................
Patch Set 4: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/4779/3/be/src/service/query-exec-state.cc File be/src/service/query-exec-state.cc: Line 547: } > I think this could go in UnregisterQuery too. I put it here because I thoug I don't have a strong preference either way -- mostly wondering what the reasoning was. The division between the two don't seem very clear (i.e. its not clear why some stuff in Unregister() isn't in Done()), but I agree Unregister() doesn't seem any better. -- To view, visit http://gerrit.cloudera.org:8080/4779 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6bcb5fc218ad4ab935343a55b2188441d8c7dfbd Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-HasComments: Yes
