Lars Volker has posted comments on this change. Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input ......................................................................
Patch Set 4: (2 comments) Thanks Tim for having a look. Please see PS4. http://gerrit.cloudera.org:8080/#/c/4863/1//COMMIT_MSG Commit Message: PS1, Line 7: A- > - instead of _ Done Line 12: > RE: testing - off the top of my head, I think we need: Thanks for the feedback. I added tests addressing points 1 to 3 and an explanation in the commit message. I also added different row batch sizes to the exhaustive run of insert.test. -- To view, visit http://gerrit.cloudera.org:8080/4863 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibeda0bdabbfe44c8ac95bf7c982a75649e1b82d0 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
