Lars Volker has posted comments on this change. Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input ......................................................................
Patch Set 7: (1 comment) Thanks Tim, for the review. I pushed PS7, removing a DCHECK I had added - though I'm not quite sure why it gets hit. Marcel, can you have a look at PS7 for a +2? http://gerrit.cloudera.org:8080/#/c/4863/6/be/src/exec/hdfs-table-sink.cc File be/src/exec/hdfs-table-sink.cc: Line 395: // Build the unique name for this partition from the partition keys, e.g. "j=1/f=foo/" The insert tests are hitting this DCHECK. Without it they pass, though it is not entirely clear to me why, yet. -- To view, visit http://gerrit.cloudera.org:8080/4863 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibeda0bdabbfe44c8ac95bf7c982a75649e1b82d0 Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
