Tim Armstrong has posted comments on this change. Change subject: Add all build targets to CMake and speed up builds ......................................................................
Patch Set 5: There were a couple of races exposed by running builds with different settings: * The shell tarball must depend on thrift-deps * impala-config.sh had side-effects that caused problems if run concurrently I've included fixes for both in the latest patch -- To view, visit http://gerrit.cloudera.org:8080/4790 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23617adf13bdeb034c24f6bba14b5ae480e8dd26 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbap...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: No