Jim Apple has posted comments on this change. Change subject: Add all build targets to CMake and speed up builds ......................................................................
Patch Set 5: > I'm holding off on merging this until builds stabilise a little > more, since it's not a high priority to get in immediately. You might want to rebase and try running a GVM dry-run in the public Jenkins. Dry-runs will run all the tests but won't +1 or submit this job. One of the tests that gets run is bootstrap_build.sh. Another runs with a variety of build flags (asan, so, release, and so on). You can check if these break and if they get any faster than usual. -- To view, visit http://gerrit.cloudera.org:8080/4790 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23617adf13bdeb034c24f6bba14b5ae480e8dd26 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: No