anujphadke has posted comments on this change. Change subject: IMPALA-2057: Better error message for incorrect avro decimal column declaration ......................................................................
Patch Set 2: 1. check if a logical type is present, and throw an exception if it's non-NULL (since BYTES requires a logical type) - Moved the the check before calling getDecimalType 2. call getDecimalType(schema, logicalType) - Done 3. getDecimalType() should now either return a valid type or throw an exception. Done. -- To view, visit http://gerrit.cloudera.org:8080/5255 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iad23706128223b6537d565471ef5d8faa91b0b5a Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: anujphadke <apha...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: anujphadke <apha...@cloudera.com> Gerrit-HasComments: No
