Tim Armstrong has posted comments on this change. Change subject: IMPALA-2057: Better error message for incorrect avro decimal column declaration ......................................................................
Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/5255/3/fe/src/main/java/org/apache/impala/util/AvroSchemaParser.java File fe/src/main/java/org/apache/impala/util/AvroSchemaParser.java: Line 139: "Unsupported logicalType: " + logicalType)); Should also include something like "for column '%s' with type BYTES" so users can understand better what happened. PS3, Line 180: , String logicalType Unused argument -- To view, visit http://gerrit.cloudera.org:8080/5255 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iad23706128223b6537d565471ef5d8faa91b0b5a Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: anujphadke <apha...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: anujphadke <apha...@cloudera.com> Gerrit-HasComments: Yes