Michael Ho has posted comments on this change. Change subject: IMPALA-4594: WriteSlot and CodegenWriteSlot handle escaped NULL slots differently ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/5377/2/be/src/exec/hdfs-scanner.cc File be/src/exec/hdfs-scanner.cc: PS2, Line 468: twos_compliment_len abs_len or positive_len ? PS2, Line 469: ones_compliment_len, codegen->GetIntConstant(TYPE_INT, 1), "twos_compliment_len"); nit: long line http://gerrit.cloudera.org:8080/#/c/5377/2/be/src/exec/text-converter.cc File be/src/exec/text-converter.cc: PS2, Line 171: // The len can be less than 0 if the field contained an escape character which : // is only valid for string cols. Remove. -- To view, visit http://gerrit.cloudera.org:8080/5377 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I858e427ad7c2b2da8c2bb657be06b7443655781f Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-HasComments: Yes
