Michael Ho has posted comments on this change. Change subject: IMPALA-4594: WriteSlot and CodegenWriteSlot handle escaped NULL slots differently ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/5377/2//COMMIT_MSG Commit Message: PS2, Line 10: the slots contains escape characters. May help to clarify that the problem shows up when the tuple only contains non-string slots. We don't use CodegenWriteSlot() if there is any string slots and the escape character is not null (https://github.com/apache/incubator-impala/blob/master/be/src/exec/hdfs-scanner.cc#L139). http://gerrit.cloudera.org:8080/#/c/5377/2/be/src/exec/hdfs-scanner.cc File be/src/exec/hdfs-scanner.cc: PS2, Line 460: // Convert length to positive if it is negative. I wonder if this should be emitted for text scanner only. I believe we only set length to negative if process_escapes is true in DelimitedTextParser::AddColumn(). Or do you think it's a good line of defense in case there are bugs in other part of the scanner ? -- To view, visit http://gerrit.cloudera.org:8080/5377 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I858e427ad7c2b2da8c2bb657be06b7443655781f Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-HasComments: Yes
