Lars Volker has posted comments on this change. Change subject: IMPALA-4403: Implement SHOW RANGE PARTITIONS for Kudu tables ......................................................................
Patch Set 4: (3 comments) Please see PS5 http://gerrit.cloudera.org:8080/#/c/5390/4//COMMIT_MSG Commit Message: PS4, Line 9: This is a rough draft and should serve as a base for discussion on how : to properly implement this. I'm happy to add another command to the : catalog to handle show partitions separately from show stats. We might : as well merge this change now and then clean it up properly in a : subsequent change. : : Also I'm happy to add more tests if needed, e.g. to the AnalyzerTests. > can you update this now? Done http://gerrit.cloudera.org:8080/#/c/5390/4/testdata/workloads/functional-query/queries/QueryTest/kudu_partition_ddl.test File testdata/workloads/functional-query/queries/QueryTest/kudu_partition_ddl.test: PS4, Line 97: 'VALUES = (10, "martin")' : 'VALUES = (20, "dimitris")' : 'VALUES = (30, "matthew")' > did you fetch the latest kudu client jar from mvn? VALUES should be VALUE. Cleaning ~/.m2 and rebuilding from scratch seemed to help. http://gerrit.cloudera.org:8080/#/c/5390/4/tests/query_test/test_kudu.py File tests/query_test/test_kudu.py: PS4, Line 133: assert False > ? Done -- To view, visit http://gerrit.cloudera.org:8080/5390 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idf5b2fdd02938a42fa59ec98884e4ac915dd1f65 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-HasComments: Yes
