Alex Behm has posted comments on this change. Change subject: IMPALA-4403: Implement SHOW RANGE PARTITIONS for Kudu tables ......................................................................
Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/5390/6/fe/src/main/java/org/apache/impala/analysis/ShowStatsStmt.java File fe/src/main/java/org/apache/impala/analysis/ShowStatsStmt.java: Line 71: if (table_.getNumClusteringCols() == 0) { Show table/column stats should be ok for unpartitioned tables. Line 85: } else if (table_ instanceof View) { seems simpler in my mind if we move this to the top as its own check (without an else if) -- To view, visit http://gerrit.cloudera.org:8080/5390 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idf5b2fdd02938a42fa59ec98884e4ac915dd1f65 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-HasComments: Yes
