Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4614: Set eval cost of timestamp literals. ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5404/1/fe/src/main/java/org/apache/impala/analysis/LikePredicate.java File fe/src/main/java/org/apache/impala/analysis/LikePredicate.java: PS1, Line 164: evalCost_ = -1; Can't we just initialize this in the constructor of Expr instead of adding all these else blocks? -- To view, visit http://gerrit.cloudera.org:8080/5404 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife30420bafbd1c64a5e3385e5755909110b4b354 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-HasComments: Yes
