Alex Behm has uploaded a new patch set (#2). Change subject: IMPALA-4614: Set eval cost of timestamp literals. ......................................................................
IMPALA-4614: Set eval cost of timestamp literals. The main issue was that the eval cost was not set for timestamp literals, so a preconditions check was hit when trying to order a list of conjuncts by cost. Another subtle issue made the bug only reproducible by a specific query against a Kudu table in our tests, although the bug is not Kudu specific: The eval cost of Exprs was not recomputed in analyze(), even after resetting an Expr, e.g., during a substitution. As a result, the bug was only reproducible for a list of conjuncts that contained an inferred predicate with a timestamp literal. This patch does not contain a fix for that issue due to its complexity/risk. It is tracked in IMPALA-4620. Testing: Ran planner tests locally. Ran query_test.py locally. A private core/hdfs run passed. Change-Id: Ife30420bafbd1c64a5e3385e5755909110b4b354 --- M fe/src/main/java/org/apache/impala/analysis/TimestampLiteral.java M testdata/workloads/functional-planner/queries/PlannerTest/conjunct-ordering.test 2 files changed, 21 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/04/5404/2 -- To view, visit http://gerrit.cloudera.org:8080/5404 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ife30420bafbd1c64a5e3385e5755909110b4b354 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com>
