Dimitris Tsirogiannis has posted comments on this change.
Change subject: IMPALA-4768: Improve logging of table loading.
......................................................................
Patch Set 3:
(2 comments)
Overall, not a big fan of this change. There are better ways to generate
logging of important function calls without adding matching
LOG.info("Starting...") - LOG.info("Started...") at the beginning and end of
each function. That said, if we believe these new statements really help us
debug the catalog, I will not object this change.
http://gerrit.cloudera.org:8080/#/c/5709/3/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java:
PS3, Line 241: BlockMetadataLoadStats
I don't see any block-metadata-specific stats, so I am wondering if the name of
this class is accurate.
PS3, Line 244: // Number of files that were found to belong to the table being
loaded.
: public long tableFileCount = 0;
Not sure I understand what this field represents? Can you please explain ?
--
To view, visit http://gerrit.cloudera.org:8080/5709
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8de96d0cb6d09b2272b1925d42cb059367fe7196
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <alex.b...@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com>
Gerrit-HasComments: Yes
