Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4768: Improve logging of table loading. ......................................................................
Patch Set 4: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/5709/4/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: PS4, Line 327: if (unknownDiskIdCount > 0) { : if (LOG.isWarnEnabled()) { : LOG.warn("Unknown disk id count for filesystem " + fs + ":" + : unknownDiskIdCount); : } : } Do we print for every file? Shouldn't this be outside the while loop? PS4, Line 753: Loading "Loaded" -- To view, visit http://gerrit.cloudera.org:8080/5709 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8de96d0cb6d09b2272b1925d42cb059367fe7196 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-HasComments: Yes
