Alex Behm has posted comments on this change. Change subject: IMPALA-4822: Implement dynamic log level changes ......................................................................
Patch Set 7: (7 comments) http://gerrit.cloudera.org:8080/#/c/5792/7/be/src/util/backend-gflag-util.h File be/src/util/backend-gflag-util.h: Line 29: extern int FLAGS_v_default; Placement seems awkward. Maybe we can move thins into logging-support.h/cc and set it in a new function InitDynamicLogLevels(). That function would remember the default glog level and also load the Java classes. InitDynamicLogLevels() would be called inside InitCommonRuntime() http://gerrit.cloudera.org:8080/#/c/5792/7/be/src/util/logging-support.cc File be/src/util/logging-support.cc: Line 243: StringParser::StringToInt<int>(glog_level->second.c_str(), use data() instead of c_str() Line 247: Status s("Bad glog level input. Valid inputs are integers in [0-3] range."); in the [0-3] range http://gerrit.cloudera.org:8080/#/c/5792/7/tests/webserver/test_web_pages.py File tests/webserver/test_web_pages.py: Line 54: self.get_and_check_status("http://localhost:25000/log_level";) let's also test these for the statestored and catalogd like in the memz test above Line 83: set_glog_url =\ extra space Line 103: set_glog_url =\ extra space Line 116: set_glog_url =\ extra space -- To view, visit http://gerrit.cloudera.org:8080/5792 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I588418e9bcb0b66d33138baf96207a5a35bfbd63 Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-HasComments: Yes
