Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4822: Implement dynamic log level changes ......................................................................
Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/5792/7/common/thrift/Logging.thrift File common/thrift/Logging.thrift: PS7, Line 45: TResetJavaLogLevelParams > We could pass them along with all the other BE gflags in GetThriftBackendGf We already do that [1], just that we don't save them in the frontend anywhere to be used later. [1] https://github.com/cloudera/Impala/blob/cdh5-trunk/be/src/util/backend-gflag-util.cc#L67-L68 -- To view, visit http://gerrit.cloudera.org:8080/5792 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I588418e9bcb0b66d33138baf96207a5a35bfbd63 Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-HasComments: Yes