Zach Amsden has posted comments on this change. Change subject: IMPALA-2020: Inline big number strings ......................................................................
Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/5902/5/be/src/exprs/expr-value.h File be/src/exprs/expr-value.h: Line 177: decimal4_val = +DecimalUtil::MAX_UNSCALED_DECIMAL4; Unary plus necessary to convert to an Rvalue http://gerrit.cloudera.org:8080/#/c/5902/4/be/src/util/decimal-util.cc File be/src/util/decimal-util.cc: Line 25 > If it's going to be this specific, why not Let's go full tilt and actually fully inline this :) -- To view, visit http://gerrit.cloudera.org:8080/5902 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5095a366d914cebb0b64bd434a08dbb55c90ed30 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden <zams...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Zach Amsden <zams...@cloudera.com> Gerrit-HasComments: Yes
