Dan Hecht has posted comments on this change. Change subject: IMPALA-2020: Inline big number strings ......................................................................
Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/5902/8/be/src/util/decimal-util.h File be/src/util/decimal-util.h: Line 233: return MAX_UNSCALED_DECIMAL16 / GetConstScaleMultiplier<int128_t>(scale); multi-line if-stmts need braces per our style -- To view, visit http://gerrit.cloudera.org:8080/5902 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5095a366d914cebb0b64bd434a08dbb55c90ed30 Gerrit-PatchSet: 8 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden <zams...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Zach Amsden <zams...@cloudera.com> Gerrit-HasComments: Yes
