Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4902: Copy parameters map in HdfsPartition.toThrift(). ......................................................................
Patch Set 2: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/6127/1/fe/src/main/java/org/apache/impala/catalog/Table.java File fe/src/main/java/org/apache/impala/catalog/Table.java: Line 72: private final ReentrantLock tableLock_ = new ReentrantLock(); > This change is not necessary for this fix, I can remove it if you prefer. I don't have a strong opinion on this but I lean towards fairness because the lock is served to the longest waiting thread and that seems more reasonable to me. -- To view, visit http://gerrit.cloudera.org:8080/6127 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic11277ad5512d2431cd3cc791715917c95395ddf Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-HasComments: Yes
