Alex Behm has posted comments on this change. Change subject: IMPALA-4902: Copy parameters map in HdfsPartition.toThrift(). ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6127/1/fe/src/main/java/org/apache/impala/catalog/Table.java File fe/src/main/java/org/apache/impala/catalog/Table.java: Line 72: private final ReentrantLock tableLock_ = new ReentrantLock(); > I don't have a strong opinion on this but I lean towards fairness because t I can see how it would make sense to keep fairness to prevent starvation. But we always tryLock() in a loop until we get it, so we're not preventing starvation. In fact, threads never wait for this lock (they just try and loop), so making this lock fair seems pretty misleading to me. -- To view, visit http://gerrit.cloudera.org:8080/6127 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic11277ad5512d2431cd3cc791715917c95395ddf Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-HasComments: Yes
