Lars Volker has posted comments on this change. Change subject: IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader() ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6328/1//COMMIT_MSG Commit Message: Line 13: I verified that the other uses of status are ok. Most do not check status.ok() I think we should change GetBytes() to always initialize status. The function comment even seems vague on this, so we should update it, too. Does any of the other uses rely on the fact that status does not get changed if no error occurs? If so, I think we should revisit that code. -- To view, visit http://gerrit.cloudera.org:8080/6328 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie22a8cf6b53f507c378c2efe302482409935184e Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-HasComments: Yes
