Lars Volker has posted comments on this change.

Change subject: IMPALA-5055: Fix DCHECK in parquet-column-readers.cc 
ReadPageHeader()
......................................................................


Patch Set 1:

Since we expect no performance penalty and consumers shouldn't rely on status 
being untouched, can initialize it to OK() in GetBytes and do a private perf 
run to see whether it has a perf impact? I think that would eliminate a 
potential cause for future problems.

-- 
To view, visit http://gerrit.cloudera.org:8080/6328
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie22a8cf6b53f507c378c2efe302482409935184e
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com>
Gerrit-Reviewer: Lars Volker <l...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-HasComments: No

Reply via email to