Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4041: Limit catalog and admission control updates to coordinators ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6344/1/be/src/scheduling/admission-controller.cc File be/src/scheduling/admission-controller.cc: Line 229: Status AdmissionController::Init(StatestoreSubscriber* subscriber) { > Ah, so the admission controller should be initialized in a 'executor-only' Yeah, we need to at least execute the 'AddPoolUpdates' part of the callback. An executor-only mode is a good way to put it. I agree avoiding the scheduler initialization would be nice. I can't remember if there was a reason why the AC was owned by the scheduler but it seems reasonable to hoist it up to ExecEnv. -- To view, visit http://gerrit.cloudera.org:8080/6344 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f2c74abdbcd60ac050efa323616bd41182ceff3 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-HasComments: Yes
