Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4041: Limit catalog and admission control updates to coordinators ......................................................................
Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/6344/1/be/src/scheduling/admission-controller.cc File be/src/scheduling/admission-controller.cc: Line 229: Status AdmissionController::Init(StatestoreSubscriber* subscriber) { > Yeah, we need to at least execute the 'AddPoolUpdates' part of the callback Done. Extracted the AdmissionController out of the Scheduler. Line 230: if (!FLAGS_is_coordinator) return Status::OK(); > This shouldn't even get called if is_coordinator is false. I think you shou Done http://gerrit.cloudera.org:8080/#/c/6344/1/be/src/service/impala-server.cc File be/src/service/impala-server.cc: Line 1888: if (be_port != 0 && be_server != NULL) { > move this above line 1844, then return if this isn't a coordinator. Done http://gerrit.cloudera.org:8080/#/c/6344/1/be/src/service/impala-server.h File be/src/service/impala-server.h: Line 948: /// If beeswax_port != 0 (and fe_server != NULL), creates a ThriftServer exporting > update comments with new semantics. Done http://gerrit.cloudera.org:8080/#/c/6344/1/bin/start-impala-cluster.py File bin/start-impala-cluster.py: Line 246: args = "-is_coordinator=true %s" % (args) > leave this out. it's the default, and we should make sure it actually works Done http://gerrit.cloudera.org:8080/#/c/6344/1/tests/custom_cluster/test_coordinators.py File tests/custom_cluster/test_coordinators.py: Line 76: self.execute_query_expect_success(client1, "drop database %s cascade" % db_name) > why don't you add running a query against impalads[2] (and failing), and th Done -- To view, visit http://gerrit.cloudera.org:8080/6344 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f2c74abdbcd60ac050efa323616bd41182ceff3 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-HasComments: Yes
