Dan Hecht has posted comments on this change. Change subject: IMPALA-5192: Don't bake MemPool* into IR ......................................................................
Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/6657/3/be/src/codegen/codegen-anyval.cc File be/src/codegen/codegen-anyval.cc: PS3, Line 528: CodegenAllocate okay to ignore, but I think this would be clearer if called CodegenMemPoolAllocate(). http://gerrit.cloudera.org:8080/#/c/6657/3/be/src/runtime/tuple.cc File be/src/runtime/tuple.cc: PS3, Line 344: // Value* non_null_string_values_arg = args[5]; // unused : // Value* total_string_lengths_arg = args[6]; // unused : // Value* num_non_null_string_values_arg = args[7]; // unused what does this mean? that these out-parameters can't be used with codegen? do we document that somewhere? http://gerrit.cloudera.org:8080/#/c/6657/3/be/src/runtime/tuple.h File be/src/runtime/tuple.h: PS3, Line 121: . it would probably be good to mention the equivalent thing about codegen -- that it has to match up with the use_mem_pool argument to CodegenMaterializeExprs() PS3, Line 167: There are two different MaterializeExprs symbols to differentiate between : /// these cases when we replace the function calls during codegen. what is this referring to exactly? we generate two versions of the same function? i don't see where that happens. -- To view, visit http://gerrit.cloudera.org:8080/6657 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09d620e48032351ab9805825a4afb6536bed2302 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
