Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-5188: Add slot sorting in TupleDescriptor::LayoutEquals() ......................................................................
Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/6610/4/be/src/runtime/descriptors.cc File be/src/runtime/descriptors.cc: Line 346: // originals. > i think a comment like this would be better at the slots_ field definition. Removed the comment here and added the comment you suggested to the slots_ field definition. Line 360: std::sort(other_slots.begin(), other_slots.end(), SlotComparator()); > Or maybe TupleDescriptor::SlotsOrderedbyIdx()? Done, refactored, also removed comment and DCHECKS. -- To view, visit http://gerrit.cloudera.org:8080/6610 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I426ad244678dbfe517262dfb7bbf4adc0247a35e Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-HasComments: Yes
