Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-5188: Add slot sorting in TupleDescriptor::LayoutEquals() ......................................................................
Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/6610/5/be/src/runtime/descriptors.h File be/src/runtime/descriptors.h: Line 131: int slot_idx() const { return slot_idx_; } > this doesn't need to be exposed, so let's remove it. TupleDescriptor is alr Done Line 426: vector<SlotDescriptor*> SlotsOrderedByIdx() const; > this shouldn't be pubic either. Done -- To view, visit http://gerrit.cloudera.org:8080/6610 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I426ad244678dbfe517262dfb7bbf4adc0247a35e Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-HasComments: Yes
