Dan Hecht has posted comments on this change.

Change subject: IMPALA-1972/IMPALA-3882: Fix QueryExecState::lock_ contention
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/6707/2//COMMIT_MSG
Commit Message:

Line 22: and run parallel queries.
> Load isn't relevant. The lock dependency is the problem, so as long as you 
And can you first just try to reproduce the problem manually by doing those 
steps:

1) Executes a query and simulates getting stuck in planning (loop forever).
2) see if the debug webpage is stuck. It should be since you're holding a QES 
lock.
3) Execute a second query. Now this query should not even be able to register 
since the webserver is holding the map lock (while waiting for the QES::lock of 
#1).


http://gerrit.cloudera.org:8080/#/c/6707/3/be/src/service/impala-http-handler.cc
File be/src/service/impala-http-handler.cc:

PS3, Line 722: ate->query_status();
not sure if that's what we should put. Let's see what Henry suggests.


-- 
To view, visit http://gerrit.cloudera.org:8080/6707
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie44daa93e3ae4d04d091261f3ec4891caffe8026
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada <bhara...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-HasComments: Yes

Reply via email to