Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-1972/IMPALA-3882: Fix QueryExecState::lock_ contention ......................................................................
Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/6707/2//COMMIT_MSG Commit Message: Line 22: - As an exception, we don't grab QES::lock_ while the query planning is > Any luck with reproducing that scenario? The bug was exactly what we are discussing in the other comment. My test was waiting on ExecuteInternal() to return and by that time, the metadata pause has already completed. I rewrote the test to scrape the inflight_running_queryids page to pickup the id and then poll the webpage. It consistently fails without the patch. http://gerrit.cloudera.org:8080/#/c/6707/3/be/src/service/impala-server.cc File be/src/service/impala-server.cc: PS3, Line 603: // For queries in CREATED state, the profile information isn't populated yet. : if (exec_state->query_state() == beeswax::QueryState::CREATED) return Status::OK(); > Is it possible to get to this method for a query that hasn't returned from I think it is possible. Reason being, the /queries page polls the query_exec_state_map_ to get the running queries and display on the UI. So, as long as the RegisterQuery() returns, it shows up on the UI (the metadata loading happens right after that). Beeswax/HS2 clients though would block on the ExecuteInternal() call and wait for the metadata to be loaded to get the query_handle. http://gerrit.cloudera.org:8080/#/c/6707/3/www/query_plan.tmpl File www/query_plan.tmpl: PS3, Line 42: {{?plan_metadata_unavailable}} : <h3> Query plan information is not yet available since the planning hasn't finished.</h3> : {{/plan_metadata_unavailable}} : : {{^plan_metadata_unavailable}} > Since the webpage refreshes every few seconds, it would be best to have thi Done -- To view, visit http://gerrit.cloudera.org:8080/6707 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie44daa93e3ae4d04d091261f3ec4891caffe8026 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-HasComments: Yes
