Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5333: Add support for Impala to work with ADLS ......................................................................
Patch Set 2: Code-Review+1 (3 comments) Functionally I think this ok, there's not really that much code. However, I'm a bit worried about the lack of real/larger tests and infra gaps preventing nightly runs. That doesn't have to hold up this review though, as long as we have a plan. http://gerrit.cloudera.org:8080/#/c/6910/2/tests/metadata/test_ddl.py File tests/metadata/test_ddl.py: PS2, Line 61: will may? http://gerrit.cloudera.org:8080/#/c/6910/2/tests/query_test/test_insert_parquet.py File tests/query_test/test_insert_parquet.py: Line 164: #@SkipIfADLS.hdfs_block_size now it's commented out http://gerrit.cloudera.org:8080/#/c/6910/1/tests/util/adls_util.py File tests/util/adls_util.py: PS1, Line 47: : def copy(self, src, dst): > When you click the [source] link on that, we get this: hah -- To view, visit http://gerrit.cloudera.org:8080/6910 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic56b9988b32a330443f24c44f9cb2c80842f7542 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-HasComments: Yes
