David Knupp has posted comments on this change. Change subject: IMPALA-5333: Add support for Impala to work with ADLS ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/6910/2/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: Line 54: from tests.util.filesystem_utils import IS_S3, S3_BUCKET_NAME, IS_ADLS, ADLS_STORE_NAME, \ This is a nit, but once the import list becomes this long, a common idiom is to use... from tests.util.filesystem_utils import ( IS_S3, S3_BUCKET_NAME, IS_ADLS, ADLS_STORE_NAME, ... ) Line 76: assert IS_ADLS == False, "Need the ADLSClient for testing with ADLS" Is covering the ImportError with an AssertionError funky? Might it be better for debugging if we do something like: if IS_ADLS: try: from tests.util.adls_util import ADLSClient except ImportError: LOG.error("Need the ADLSClient for testing with ADLS") raise ? -- To view, visit http://gerrit.cloudera.org:8080/6910 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic56b9988b32a330443f24c44f9cb2c80842f7542 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-HasComments: Yes
