Vincent Tran has posted comments on this change. Change subject: IMPALA-5316: Adds last_day() function ......................................................................
Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/6991/2/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: Line 279: void TestLastDayFunction() { > I didn't mean in automated tests but rather checking by manual inspection, Done http://gerrit.cloudera.org:8080/#/c/6991/3/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: Line 285: TestTimestampValue("last_day('2003-03-02 03:21:12.0058')", > add some fractional seconds too Done http://gerrit.cloudera.org:8080/#/c/6991/3/be/src/exprs/timestamp-functions.h File be/src/exprs/timestamp-functions.h: PS3, Line 199: date c > Impala doesn't have a DATE type so this is misleading. I think you can say Done -- To view, visit http://gerrit.cloudera.org:8080/6991 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I429c8734bddca3c37a2eedc211a16a4ffcb04370 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Vincent Tran <vtt...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Vincent Tran <vtt...@cloudera.com> Gerrit-HasComments: Yes
