Alex Behm has posted comments on this change. Change subject: IMPALA-5316: Adds last_day() function ......................................................................
Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/6991/6/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: Line 279: void TestLastDayFunction() { Vincent, MJ, I don't really see how this code is executed, are you sure these tests are running? I don't see this code called from a GTest test. You should put these test cases into a GTest like this: TEST_F(ExprTest, LastDay) { // Code goes here } The ExprTest class should only contain helper functions and not test cases. -- To view, visit http://gerrit.cloudera.org:8080/6991 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I429c8734bddca3c37a2eedc211a16a4ffcb04370 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Vincent Tran <vtt...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Vincent Tran <vtt...@cloudera.com> Gerrit-HasComments: Yes
