Henry Robinson has posted comments on this change. Change subject: IMPALA-5394: Set socket timeouts while opening TSaslTransport ......................................................................
Patch Set 2: Thanks for the write-up, very helpful! For backend services we have TAcceptQueueServer which moves accept()'ed sockets onto a thread pool for calling open(). See IMPALA-4135, and https://github.com/apache/incubator-impala/commit/a9c40595549bfb74d2b9796a0a7098361793492e. It looks like from your stack trace You might look into that as a drop-in replacement (I think you need to change the HS2 server to Threaded, from ThreadPool) to see if that shows any improvement. You might need to increase the size of the thread pool in TAcceptQueueServer::serve to >1, and implement the locking fix, to see an improvement. If that doesn't seem to work, then setting the timeouts here is ok - just want to make sure we've considered everything first. -- To view, visit http://gerrit.cloudera.org:8080/7061 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56a5f3d9cf931cff14eae7f236fea018236a6255 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Sherman <j...@arcadiadata.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: John Sherman <j...@arcadiadata.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-HasComments: No
