John Sherman has posted comments on this change. Change subject: IMPALA-5394: Set socket timeouts while opening TSaslTransport ......................................................................
Patch Set 2: Ok, my manual testing went well. Took a bit of effort to get it so I could get my bits installed in an environment with kerberos enabled. (I setup a centos dev machine and used the Cloudera Sandbox VM with kerberos enabled). The approach I tested was what Henry suggested (which was to use the AcceptQueueServer implementation, increase the number of connection setup threads, and fix the locking), I also opted to keep the timeouts. I'm now loading the testdata and running the regression tests locally, once they (hopefully) pass I'll post the updated review (likely tomorrow). -- To view, visit http://gerrit.cloudera.org:8080/7061 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56a5f3d9cf931cff14eae7f236fea018236a6255 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Sherman <j...@arcadiadata.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: John Sherman <j...@arcadiadata.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-HasComments: No
