Michael Ho has posted comments on this change. Change subject: IMPALA-5388: Only retry RPC on lost connection in send call ......................................................................
Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/7063/8/be/src/runtime/client-cache.h File be/src/runtime/client-cache.h: Line 310: // TODO: ThriftClient should return proper error codes. > DCHECK(client_is_unrecoverable_); Done Line 316: try { > nit: Should we add a higher level LOG here stating the retry? We already have a log statement in Reopen(). If Reopen() fails, we should log in line 314 so I guess it should be okay to skip the log statement here. Are you concerned about certain cases in which the log statement will help us with debugging ? -- To view, visit http://gerrit.cloudera.org:8080/7063 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I176975f2aa521d5be8a40de51067b1497923d09b Gerrit-PatchSet: 8 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Alan Choi <a...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Juan Yu <j...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
