Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5388: Only retry RPC on lost connection in send call ......................................................................
Patch Set 8: (1 comment) I looked at the TSaslTransport layer since it seemed like we didn't vet that along with TSocket and TSSLSocket, there are a couple of places where exceptions can be thrown (during reads and writes, not during SASL negotiation), but if we're going to treat them the same as TSSLExceptions, then we can leave the code as it is, i.e. just return a RPC_GENERAL_ERROR. Just wanted to add this as a note here. http://gerrit.cloudera.org:8080/#/c/7063/8/be/src/runtime/client-cache.h File be/src/runtime/client-cache.h: Line 316: try { > We already have a log statement in Reopen(). If Reopen() fails, we should l Good point. I think that should be fine since we only call Reopen() here and nowhere else. -- To view, visit http://gerrit.cloudera.org:8080/7063 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I176975f2aa521d5be8a40de51067b1497923d09b Gerrit-PatchSet: 8 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Alan Choi <a...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Juan Yu <j...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
