Michael Ho has posted comments on this change. Change subject: IMPALA-5388: Only retry RPC on lost connection in send call ......................................................................
Patch Set 10: (6 comments) http://gerrit.cloudera.org:8080/#/c/7063/9/be/src/rpc/thrift-util.cc File be/src/rpc/thrift-util.cc: PS9, Line 194: possible > can you make this a static assert? Otherwise we might not hit this as early Done http://gerrit.cloudera.org:8080/#/c/7063/9/be/src/runtime/client-cache.h File be/src/runtime/client-cache.h: PS9, Line 297: std::s > this should be std::string (I think some google header rudely uses std :/). Done PS9, Line 298: $0 > nit: prefer "hit an" or "saw an" Done PS9, Line 299: TNetwor > TNetworkAddressToString(address_) (match the other exception messages, not Done http://gerrit.cloudera.org:8080/#/c/7063/9/be/src/testutil/fault-injection-util.cc File be/src/testutil/fault-injection-util.cc: PS9, Line 69: // by IsSendFailTException(). > it's unlikely in the extreme, but you could never take this branch if 1024 Done http://gerrit.cloudera.org:8080/#/c/7063/9/tests/custom_cluster/test_rpc_exception.py File tests/custom_cluster/test_rpc_exception.py: PS9, Line 27: # This que > can you comment to say that proper test coverage relies on sending Transmit Done -- To view, visit http://gerrit.cloudera.org:8080/7063 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I176975f2aa521d5be8a40de51067b1497923d09b Gerrit-PatchSet: 10 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Alan Choi <a...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Juan Yu <j...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
